Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted Instagram, Linkedin and GMB service for basic plan #988

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

girishpanchal30
Copy link
Contributor

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 10, 2024

Plugin build for c4e7a6d is ready 🛎️!

@rodica-andronache
Copy link

@girishpanchal30 when using just the Free version, when you try to add an account for FB or Twitter, the layout of the page changes ( the buttons from the sidebar, move at the bottom of the page, in the background ). Also, the popup is more shrinked than before.
I tried to show this in the video, comparing it to the current version of the plugin
https://vertis.d.pr/v/gSHuyV

@girishpanchal30
Copy link
Contributor Author

@rodica-andronache I've tested with local and it seems not to break any UI, Can you please share your test instance details here?
Ref: https://tinyurl.com/263bsuvn

@rodica-andronache
Copy link

@girishpanchal30

https://exotic-mamba-29f6e6.vertisite.cloud/wp-admin/admin.php?page=TweetOldPost
user: rodica
pass: rodica

@girishpanchal30
Copy link
Contributor Author

@rodica-andronache Now I've tested with local and browserstack it seems working properly. Please check the private window and let me know
Ref: https://tinyurl.com/23qslh9s

@rodica-andronache
Copy link

@girishpanchal30
Copy link
Contributor Author

@rodica-andronache Can you please recheck with the latest build zip? it seems issue with some style/css

@rodica-andronache
Copy link

@girishpanchal30 yes, that layout shift is not happening anymore.
Just the popup for twitter appears different for me, than in the current version. Its smaller ( the title does not fit on one line ), and the button doesn't have a border anymore

Current version
Screenshot on 2024-07-10 at 15-37-49

With this PR
Screenshot on 2024-07-10 at 15-37-42

@girishpanchal30
Copy link
Contributor Author

@rodica-andronache Fixed, It happened because we have removed the modal footer notice(#980) and some CSS issues with the new ROP version.

@rodica-andronache
Copy link

@girishpanchal30 thank you, now the popup is fine 👍 I'll wait for an answer from @stefan-cotitosu here https://github.com/Codeinwp/tweet-old-post-pro/issues/527#issuecomment-2220424132 to move it to Ready to Merge

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 3110372 into development Jul 12, 2024
5 of 6 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 9.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants