This repository has been archived by the owner on May 5, 2021. It is now read-only.
Optimizations and Cycle effect #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 16, 2012 03:53
Removed unneeded jQuery selector
… loops Replaced selector filters with chained filters Reworked slices/boxes creation functions to cache HTML and append as a whole Added many cache variables
Improved some loops
Fixed boxRain effect incrementing in the wrong place causing the trigger to fire many times.
| //Trigger the beforeChange callback | ||
| settings.beforeChange.call(this); | ||
|
|
||
|
|
||
| //Set current background before change | ||
| if(!nudge){ |
There was a problem hiding this comment.
I'm wondering why this extensive if statement containing the same thing is even here. Is it for a future feature or have you removed something previously and forgot to remove it?
added 10 commits
January 21, 2012 03:32
…e type Combined 'slideInLeft' & 'slideInRight' effects Added previousSlideIndex var Fixed 'slideInLeft' effect Improved 'boxRain' loop Repacked Added official Mario quote
Added overflow hidden to CSS nivoSlider class for cycle effect Added slice limit attribute to createSlices function Repacked
Repacked
Changed slide link removal time to beginning of animation. Repacked.
Added jQuery externs file for use when packing with Google Closure Compiler advanced.
Improved readme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've optimized to town and added cycle, cycleLeft & cycleRight effects now. NivoSlider finally slides!
My minified version is 9000~ bytes.