Syncing workspace and code #51
Conversation
ashwinKumar0505
force-pushed
the
syncing-workspace-and-code
branch
from
ee4f7d3
to
8a17258
Compare
ashwinKumar0505
force-pushed
the
syncing-workspace-and-code
branch
2 times, most recently
from
c93a71a
to
8e35af1
Compare
Modify sidebar
…componets-structure Building meta components from its default code
Modification of custom page
Performance improvement
Fixed the routing issue in netlify
| this.plugin = declare(() => { | ||
| return { | ||
| visitor: { | ||
| ArrowFunctionExpression: (path: any) => { |
There was a problem hiding this comment.
what if the component is not a arrow function but rather a normal es5 function?
There was a problem hiding this comment.
i thik you can use the alias Function
| } | ||
| if (childrenProp) { | ||
| dispatch.components.unexpose('children') | ||
|
|
There was a problem hiding this comment.
This clickhandler is doing way too many things. and logic which needs a seperate reducer itself.
And every time a key is pressed this handler is being redefined
| if (visitedComponentName === componentName) { | ||
| const attribute = toJsxAttribute('isContainerComponent', 'true') | ||
|
|
||
| openingElement.attributes.push(attribute) |
There was a problem hiding this comment.
why are we pushing this attribute?
|
|
||
| const index = openingElement.attributes.findIndex( | ||
| (attribute: any) => attribute.name.name === 'isCustomComponent', | ||
| ) |
There was a problem hiding this comment.
better way to remove an attribute is to use .filter and filter it out.
| import useDispatch from '../../../hooks/useDispatch' | ||
| import UnExposePropButton from '../../actionButtons/UnExposePropButton' | ||
| import CustomPropDeletionButton from '../../actionButtons/CustomPropDeletionButton' | ||
| import { checkIsCustomPage } from '../../../core/selectors/page' |
There was a problem hiding this comment.
The logic in this component is way more than what a FormControl component needs to do.
For example: this component acts differently if the form control is representing the props of a Custom Component, or the props a child components of a custom component which are exposed.
Ideally this should have been two different components itself
Testing and improving App perfomance
Improving the perfomance of the app
No description provided.