make it clear that this repo requires updating and shouldn't be used #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Dec 29, 2020
There was a problem hiding this comment.
LGTM! I did similar spinning when I first tried to contribute to CocoaPods.
It would also be great to remove the Rainforest references from https://guides.cocoapods.org/contributing/dev-environment.html. I'll make a PR for that.
|
@paulb777 Great idea. I wasn't so sure what exactly to put there instead of a simple clone and bootstrap. Thank you! |
|
@paulb777 Do you know what else needs to be done so this can get merged? |
|
@dnkoutso Can you help here? |
|
Merged. CI has been broken for a while here. We can fix but not yet. |
|
@dnkoutso 🎉 🎉 🎉 Tiny but first OSS contribution |
|
Congrats @prohoney ! 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm very happy with the days spent learning ruby, rake, rbenv, bundler and how to fix environmental issues. I think being loud and clear that the repo needs an update can save future dev time.
@dnkoutso's comment on the issue I opened: