Appease golint #11
Closed
Appease golint #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there were around a few dozen items it complained about; this eliminates all of those issues.
$ GOPATH/bin/golint . | wc -l
0
$ go test
PASS
ok apns 0.013s
ghost
self-assigned this
|
I've had a read through, seems good to me 👍 |
ghost
pushed a commit
that referenced
this pull request
Apr 22, 2014
Lately a legitimate number of package managers for Go have cropped up, but this lib came into existence when the options were a little more sparse (i.e. "breaking public API change? Fork the repo!") This supports #11 and keeps the identifiers around but outside of the normal code...for now. I'll probably wind up forking eventually, but we'll see if we can be creative in the meantime. $ $GOPATH/bin/golint . legacy.go:10:2: don't use ALL_CAPS in Go names; use CamelCase legacy.go:11:2: don't use ALL_CAPS in Go names; use CamelCase legacy.go:12:2: don't use ALL_CAPS in Go names; use CamelCase legacy.go:13:2: don't use ALL_CAPS in Go names; use CamelCase legacy.go:14:2: don't use ALL_CAPS in Go names; use CamelCase legacy.go:15:2: don't use ALL_CAPS in Go names; use CamelCase $ go test PASS ok apns 0.013s
|
@anachronistic the eternal trade-off of legacy compatibility vs simplicity! Only you can make that call. My natural inclination - given a choice of now or later - would be to break compatibility now, before more people start using the library. But on the other hand Go's lack of native versioning makes breaking changes all the more painful. Perhaps breaking compatibility can wait until asynchronous sending (#6) is done. |
|
Superseded by #13. |
ghost
closed this
ghost
removed their assignment
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appease golint
Previously there were around a few dozen items it complained about; this eliminates all of those issues.
Interface Changes
FEEDBACK_TIMEOUT_SECONDSis nowFeedbackTimeoutSecondsAPPLE_PUSH_RESPONSESis nowApplePushResponsesPUSH_COMMAND_VALUEis nowPushCommandValueMAX_PAYLOAD_SIZE_BYTESis nowMaxPayloadSizeBytesIDENTIFIER_UBOUNDis nowIdentifierUboundTIMEOUT_SECONDSis nowTimeoutSecondsTODOs