Fix: sbd-inquisitor: fail startup if pacemaker integration is disabled while SBD_SYNC_RESOURCE_STARTUP is conflicting #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SBD_PACEMAKER is set It doesn't necessarily tell whether pacemaker integration is enabled, since it can be overridden by -P or -PP option.
…ntegration is even intentionally disabled It doesn't make sense to recommend startup syncing if one doesn't even want pacemaker integration.
…d while SBD_SYNC_RESOURCE_STARTUP is conflicting And tell user to fix the configuration by either enabling SBD_PACEMAKER or explicitly disabling SBD_SYNC_RESOURCE_STARTUP. Otherwise startup of pacemaker would be hanging forever, since pacemaker only knows about SBD_SYNC_RESOURCE_STARTUP.
|
Looking good to me. |
|
test this please |
|
Guess what is in here either implements suggestions from #141 or at least doesn't contradict other possible additions mentioned there. |
Indeed so. |
|
test this please |
|
CI seems to break at random places (maybe we can gain some robustness regarding timing but we've seen issues with coverity as well) - guess it is fine though as all in all we've seen all tests passing. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And tell user to fix the configuration by either enabling SBD_PACEMAKER
or explicitly disabling SBD_SYNC_RESOURCE_STARTUP. Otherwise startup of
pacemaker would be hanging forever, since pacemaker only knows about
SBD_SYNC_RESOURCE_STARTUP.
AFAICS this is so far the best we can do to prevent cluster services from running into never ending startup, not to mention cluster services could not even be shut down under the situation.
This is to address the topic brought up from:
ClusterLabs/pacemaker#2119 (comment)
I realized this more or less matches the ideas brought up by the other PR:
#141