Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Python 3.12: SyntaxWarning: invalid escape sequence #1601

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix: Python 3.12: SyntaxWarning: invalid escape sequence #1601

merged 1 commit into from
Nov 4, 2024
+25 −25

Conversation

vvidic
Copy link
Contributor

@vvidic vvidic commented Nov 3, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.24%. Comparing base (917b0d9) to head (8fc2f01).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/utils.py 88.88% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 54.51% <36.84%> (ø)
unit 52.13% <78.94%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 88.66% <100.00%> (ø)
crmsh/log_patterns.py 69.23% <ø> (ø)
crmsh/report/collect.py 97.13% <100.00%> (ø)
crmsh/report/utils.py 99.09% <100.00%> (ø)
crmsh/sbd.py 91.96% <100.00%> (ø)
crmsh/ui_configure.py 45.09% <100.00%> (ø)
crmsh/ui_utils.py 53.15% <100.00%> (ø)
crmsh/watchdog.py 100.00% <100.00%> (ø)
crmsh/utils.py 66.70% <88.88%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nicholasyang2022
nicholasyang2022 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great! Thank you.

And we should setup a linter to check similar problems.

@nicholasyang2022 nicholasyang2022 merged commit 4972fad into ClusterLabs:master Nov 4, 2024
32 checks passed
nicholasyang2022 added a commit to nicholasyang2022/crmsh that referenced this pull request Nov 4, 2024
@nicholasyang2022
Dev: add pylint to check ill-formated string literals
fe7f066 
This pull request added pylint with a minimal configuration, enabling
only string checks.

See ClusterLabs#1601.
@nicholasyang2022 nicholasyang2022 mentioned this pull request Nov 4, 2024
Merged
liangxin1300 added a commit that referenced this pull request Nov 4, 2024
@liangxin1300
Dev: add pylint to check ill-formated string literals (#1603)
3da03cd 
This pull request added pylint with a minimal configuration, enabling
only string checks.

See #1601.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasyang2022 nicholasyang2022 nicholasyang2022 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvidic @nicholasyang2022