Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: utils: Avoid hardcoding the ssh key type as RSA #1600

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Dev: utils: Avoid hardcoding the ssh key type as RSA #1600

wants to merge 8 commits into from
+123 −104

Commits on Nov 1, 2024

  1. Dev: utils: Avoid hardcoding the ssh key type as RSA 

    In utils.ssh_copy_id_no_raise, the ssh key type is hardcoded as RSA.
Then the join process will fail if the existing key type is not RSA.

Also see:
ClusterLabs#1504 (comment)
    @liangxin1300
    liangxin1300 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d60d6d4 View commit details
    Browse the repository at this point in the history

  2. Dev: ssh_key: Avoid hardcoding the ssh key type as RSA 

    In KeyFileManager, use class variable to store the key type instead of
hardcoding it as RSA.
    @liangxin1300
    liangxin1300 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f4700eb View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Dev: bootstrap: Avoid hardcoding the ssh key type as RSA 

    Replace remote_public_key_from as ssh_key.fetch_public_key_list
    @liangxin1300
    liangxin1300 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3299d1f View commit details
    Browse the repository at this point in the history

  2. Dev: bootstrap: Change the parameter name in swap_public_ssh_key func… 

    …tion

- Change the parameter name from 'add' to 'generate_key_on_remote',
  which is more descriptive.
- In the process of join_ssh, no need to set 'generate_key_on_remote'
  to True, as the init node already has the public key.
    @liangxin1300
    liangxin1300 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b30527a View commit details
    Browse the repository at this point in the history

  3. Dev: bootstrap: Adjust the docstring of configure_ssh_key function

    @liangxin1300
    liangxin1300 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d9b36d7 View commit details
    Browse the repository at this point in the history

  4. Dev: bootstrap: Reuse AuthorizedKeyManager to add key to authorized_keys 

    And remove unused code.
    @liangxin1300
    liangxin1300 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cf92da5 View commit details
    Browse the repository at this point in the history

  5. Dev: bootstrap: Improve shell script in generate_ssh_key_pair_on_remote 

    to avoid hardcoding the ssh key type as rsa.
    @liangxin1300
    liangxin1300 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8ac3021 View commit details
    Browse the repository at this point in the history

  6. Dev: unittests: Adjust unit test for previous commits

    @liangxin1300
    liangxin1300 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ece148f View commit details
    Browse the repository at this point in the history