Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: bootstrap: Refine remote_auth stage #1598

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

liangxin1300
Copy link
Collaborator

  • Rename init_remote_auth to generate_pacemaker_remote_auth, call it in cluster stage
  • In check_stage_dependency, don't check if the stage is internal or not, just check if the stage check function returns True

Fix #1593

- Rename init_remote_auth to generate_pacemaker_remote_auth, call it
  in cluster stage
- In check_stage_dependency, don't check if the stage is internal or
  not, just check if the stage check function returns True
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.24%. Comparing base (94635ab) to head (6d9a66c).
Report is 4 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 54.51% <100.00%> (-0.01%) ⬇️
unit 52.13% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 88.66% <100.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 merged commit 917b0d9 into ClusterLabs:master Oct 29, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants