Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nicholasyang2022
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 commented May 16, 2024

This pull request implements migrating corosync.conf from corosync 2 to corosync 3, including:

  • migrate deprecated transport udpu and udp to knet
  • replace removed feature RRP with knet multilink
  • if crypto_hash is set to sha1, which is the default value in corosync 2, upgrades it to the new default in corosync 3, sha256.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 25.07123% with 263 lines in your changes missing coverage. Please review.

Project coverage is 68.62%. Comparing base (917b0d9) to head (69020cc).

Files with missing lines Patch % Lines
crmsh/migration.py 19.21% 248 Missing ⚠️
crmsh/ui_cluster.py 58.33% 15 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 54.07% <25.07%> (-0.44%) ⬇️
unit 51.70% <17.66%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/corosync.py 87.64% <100.00%> (ø)
crmsh/prun/runner.py 64.86% <100.00%> (+0.97%) ⬆️
crmsh/ui_cluster.py 73.18% <58.33%> (-1.78%) ⬇️
crmsh/migration.py 19.21% <19.21%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 force-pushed the ped-8252-20240516 branch 5 times, most recently from 3c620cf to 2d4c6db Compare May 27, 2024 08:05
@nicholasyang2022 nicholasyang2022 force-pushed the ped-8252-20240516 branch 2 times, most recently from fdcdc65 to c6cd605 Compare October 23, 2024 03:52
@nicholasyang2022 nicholasyang2022 force-pushed the ped-8252-20240516 branch 2 times, most recently from 45d2310 to 04ea10f Compare November 1, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant