tests: Remove the unit-tests directory. #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed in email, the unit-tests directory doesn't appear to do anything useful. Our options are leave it alone (which is what fooled me), try to fix it (which doesn't seem like a priority given it hasn't been touched in years), or remove it. Here's a patch that does the last. |
|
retest this please |
|
@clumens I can agree with removing unmaintained tests. Just note it is failing and there are two reasons:
|
This code doesn't work and hasn't been touched in several years. There are other ways to test booth that do work, and the fact that no one has fixed these tests means that no one thinks they are important enough to get working. So, remove them. Signed-off-by: Chris Lumens <[email protected]>
Fixed.
If you want to file an issue to deal with switching to getifaddrs, go for it. I'll take a look at some point. My current plan is to work on the crm_ticket stuff, then look through any refactoring/cleanup issues, then start to look at these kinds of improvements. |
jfriesse
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code doesn't work and hasn't been touched in several years. There are other ways to test booth that do work, and the fact that no one has fixed these tests means that no one thinks they are important enough to get working. So, remove them.