Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI Matrix for various envs #264

Merged
merged 106 commits into from
Aug 8, 2015
Merged

Add CI Matrix for various envs #264

merged 106 commits into from
Aug 8, 2015

Conversation

levice14
Copy link
Collaborator

Signed-off-by: Bonczidai Levente [email protected]

Signed-off-by: Bonczidai Levente <[email protected]>
@levice14 levice14 added this to the 0.8 - sprint 7 milestone Jul 22, 2015
@levice14 levice14 self-assigned this Jul 22, 2015
Bonczidai Levente added 13 commits July 22, 2015 14:36
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Bonczidai Levente added 10 commits July 27, 2015 10:39
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Bonczidai Levente added 7 commits August 6, 2015 17:21
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
Signed-off-by: Bonczidai Levente <[email protected]>
@levice14
Copy link
Collaborator Author

levice14 commented Aug 7, 2015

we have python code in our script which was tricky to indent since in python

    print "a"
    print "b"

gives indentation error.. so here is the scam I applied to the script:

if True:
    print "a"
    print "b"

264f815

@orius123 WDYT?

Bonczidai Levente added 3 commits August 7, 2015 10:25
@levice14
Copy link
Collaborator Author

levice14 commented Aug 7, 2015

I think I addressed all the comments:

  • added exit codes
  • moved echo statement inside if
  • used filter in python script
  • sed all over
  • extracted rule
  • indented python scripts
  • grouped and aligned commands on machines (tricky here: Yaml keys on multiple lines + bash && )

@orius123
Copy link
Contributor

orius123 commented Aug 7, 2015

forgot to exit at wait_for_droplets_and_update_test_inputs

@orius123
Copy link
Contributor

orius123 commented Aug 7, 2015

I like what you did with the indentation!

Signed-off-by: Bonczidai Levente <[email protected]>
orius123 added a commit that referenced this pull request Aug 8, 2015
Add CI Matrix for various envs
@orius123 orius123 merged commit 97db7d1 into master Aug 8, 2015
@orius123 orius123 deleted the ci-env branch August 8, 2015 17:29
@oritstone
Copy link

@orius123 we also need to merge it to cloudslang-content-0.8 branch

@orius123 orius123 restored the ci-env branch August 9, 2015 13:07
@orius123 orius123 deleted the ci-env branch August 9, 2015 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants