Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor KiD driver, add precipitation analysis #108

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Refactor KiD driver, add precipitation analysis #108

merged 2 commits into from
Jul 20, 2023

Conversation

mikhailmints
Copy link
Contributor

@mikhailmints mikhailmints commented Jul 2, 2023 •
edited
Loading

Purpose

To analyze precipitation susceptibility in the KiD model and compare it to expected results.

To-do

Content

  • Wrapped the code in KiD_driver.jl inside a function so it can be more easily called from somewhere other than the command line.
  • Added profiles of precipitation susceptibility from autoconversion and accretion to final aux profiles, using functions from CloudMicrophysics.jl
  • Added file for analyzing precipitation susceptibility from prescribed Nd by running the KiD simulation multiple times and computing finite differences, relying on a simple precipitation production metric summing ρq_rai over time at the height of the cloud base.
  • Incorporated the changes from mm/command_line_args_types, changing arg_type of arguments to Float64 instead of Real and adding the option to select Float64 or Float32 as the float type.
  • I have read and checked the items on the review checklist.

@sajjadazimi sajjadazimi self-requested a review July 3, 2023 18:59
sajjadazimi
sajjadazimi reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@sajjadazimi sajjadazimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some buildkite jobs fail. Seems like there are some minor issues. Otherwise it looks good to me. Please squash you commits when it's ready to get merged.

@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c7078df) 84.00% compared to head (f7d6a67) 84.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files          19       19           
  Lines        1613     1613           
=======================================
  Hits         1355     1355           
  Misses        258      258
Impacted Files Coverage Δ
src/driveKiD/NetCDFIO.jl 100.00% <100.00%> (ø)
src/driveKiD/TimeStepping.jl 100.00% <100.00%> (ø)
src/driveKiD/tendency.jl 86.36% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mikhailmints mikhailmints force-pushed the mm/refactor_kid_driver_add_precip_analysis branch from e12e684 to 1e81745 Compare July 4, 2023 06:03
sajjadazimi
sajjadazimi approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@sajjadazimi sajjadazimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just update the version in Project.toml (increment the patch number) and squash your commits.

@mikhailmints mikhailmints force-pushed the mm/refactor_kid_driver_add_precip_analysis branch 3 times, most recently from 262076c to cbd27bc Compare July 6, 2023 02:17
@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 6, 2023
@bors @mikhailmints
Merge #108
691b1b1 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 6, 2023
@bors @mikhailmints
Merge #108
daa7999 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 7, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jul 7, 2023
@bors
Try #108:
dc6e99b
@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 7, 2023
@bors @mikhailmints
Merge #108
6f525c5 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 7, 2023

Build failed:

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 7, 2023
@bors @mikhailmints
Merge #108
1f1a467 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 7, 2023

try

Timed out.

@bors
Copy link
Contributor

bors bot commented Jul 7, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 7, 2023
@bors @mikhailmints
Merge #108
1773eb3 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 7, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 7, 2023
@bors @mikhailmints
Merge #108
0fac4dd 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 7, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 7, 2023
@bors @mikhailmints
Merge #108
fd4e5e6 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 8, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2023
@bors @mikhailmints
Merge #108
057d763 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 8, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2023
@bors @mikhailmints
Merge #108
75e6199 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 9, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 9, 2023
@bors @mikhailmints
Merge #108
ad4aab8 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 9, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 11, 2023
@bors @mikhailmints
Merge #108
b2c46e1 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 11, 2023

Timed out.

@trontrytel
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jul 13, 2023
@bors
Try #108:
43b1103
@bors
Copy link
Contributor

bors bot commented Jul 15, 2023

try

Timed out.

@sajjadazimi
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 17, 2023
@bors @mikhailmints
Merge #108
a7c67a7 
108: Refactor KiD driver, add precipitation analysis r=sajjadazimi a=mikhailmints



Co-authored-by: Mikhail Mints <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 17, 2023

Timed out.

@sajjadazimi
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 20, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit c394ad3 into main Jul 20, 2023
7 checks passed
@bors bors bot deleted the mm/refactor_kid_driver_add_precip_analysis branch July 20, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajjadazimi sajjadazimi sajjadazimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikhailmints @sajjadazimi @trontrytel