Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the arg_type of command-line arguments for KiD_driver from Re… #107

Closed
wants to merge 1 commit into from

Conversation

mikhailmints
Copy link
Contributor

@mikhailmints mikhailmints commented Jun 22, 2023

…al to Float64

Also, enable Float32 runs

Purpose

The parsing of the command-line arguments (e.g. --t_end) was not working properly when their arg_type was set to Real:
invalid argument: 1000.0 (conversion to type Real failed; you may need to overload ArgParse.parse_item; the error was: MethodError(tryparse, (Real, "1000.0"), 0x0000000000008433))
Changing the arg_type to Float64 fixed the issue.

To-do

Content


  • I have read and checked the items on the review checklist.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c9a0675) 84.00% compared to head (6b017f6) 84.00%.

❗ Current head 6b017f6 differs from pull request most recent head 524cef1. Consider uploading reports for the commit 524cef1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files          19       19           
  Lines        1613     1613           
=======================================
  Hits         1355     1355           
  Misses        258      258           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets squash and rebase with the additional changes regarding Float32

…al to Float64, added option to specify float type.
@mikhailmints
Copy link
Contributor Author

Since I moved the code of KiD_driver.jl in mm/refactor_kid_driver_add_precip_analysis, and it will be difficult to merge, I will just replicate these changes in that branch instead of merging them separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants