Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Aerosol Coagulation #92

Closed
wants to merge 30 commits into from
Closed

[WIP] Aerosol Coagulation #92

wants to merge 30 commits into from

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Jan 18, 2023

Purpose

This PR implements coagulation via quadrature and approximation, closing #91 .

Part of the larger Aerosol Model Issue

To-do

There are a few things to do.

  • Expand testing, including:
  • Comparisons between the quadrature and Whitby approximation for the coagulation integrals.
  • plots of modal distribution change across timesteps.
  • Eventually remove Whitby approximation, since we will not include it in the final project.

Content

  • Moment-based integrals for calculating coagulation rates within and between aerosol distributions, as specified by MAM3.
  • Further information can be found in the documentation.

  • I have read and checked the items on the review checklist.

Closes #91

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -23.24 ⚠️

Comparison is base (5376eab) 97.20% compared to head (8dca58e) 73.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #92       +/-   ##
===========================================
- Coverage   97.20%   73.97%   -23.24%     
===========================================
  Files           9       11        +2     
  Lines         430      634      +204     
===========================================
+ Hits          418      469       +51     
- Misses         12      165      +153     
Impacted Files Coverage Δ
src/AerosolModel.jl 100.00% <ø> (ø)
src/CoagCorrectionFactors.jl 0.00% <0.00%> (ø)
src/Coagulation.jl 0.00% <0.00%> (ø)
src/Common.jl 100.00% <0.00%> (ø)
src/Parameters.jl 53.84% <0.00%> (ø)
src/CommonTypes.jl 100.00% <0.00%> (ø)
src/Microphysics1M.jl 100.00% <0.00%> (ø)
src/Microphysics2M.jl 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trontrytel trontrytel added this to the Aerosol Model milestone Jul 20, 2023
@nefrathenrici
Copy link
Member Author

@trontrytel I think this can be closed...

@trontrytel trontrytel closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coagulation (code and docs)
2 participants