Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

its still basically zero #478

Merged
merged 1 commit into from
Nov 8, 2024
Merged

its still basically zero #478

merged 1 commit into from
Nov 8, 2024

Conversation

trontrytel
Copy link
Member

F[3] = -1.8681f19
H[3] = -1.24394f20

For ρᵢ = 200 kg/m3 exp(-ρᵢ) = 0.0f0. Or in Float64 exp(-ρᵢ) = 1.3838965267367376e-87. So for all intents and purposes those terms are zero no matter how we write them. We would have to go down to apparent densities of 50 kg/m3 for those terms to start showing up.

But just in case, I think this implementation will behave better numerically.

@trontrytel trontrytel merged commit 28fca3d into main Nov 8, 2024
8 checks passed
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (852c662) to head (3e56f04).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          41       41           
  Lines        1601     1601           
=======================================
  Hits         1534     1534           
  Misses         67       67           
Components Coverage Δ
src 97.47% <100.00%> (ø)
ext 69.79% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants