Remove liq/ice lognormal distribution in parcel #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
reviewed
Sep 18, 2024
| @@ -46,23 +46,4 @@ function distribution_moments(::Gamma, q, N, ρ, ρ_air) | |||
| return (; r, A, V) | |||
| end | |||
|
|
|||
| function distribution_moments(params::Lognormal, q, N, ρ, ρ_air) | |||
There was a problem hiding this comment.
Thank you for doing this! I think in the same file there is also a Lognormal struct that now can be deleted?
trontrytel
approved these changes
Sep 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 41 41
Lines 1543 1543
=======================================
Hits 1496 1496
Misses 47 47
|
amylu00
force-pushed
the
al/remove_lognorm_parcel
branch
from
5cabf5a
to
0c3e082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the option to have lognormal size distribution for droplets.