Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3 shedding! #452

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

P3 shedding! #452

wants to merge 6 commits into from

Conversation

rorlija1
Copy link
Contributor

@rorlija1 rorlija1 commented Aug 27, 2024

  • This PR implements shedding for P3 liquid mass content as described in Cholette (2019).
  • See liquid fraction issue for the parameterization, or the docs build!
  • I have not added any plots to the docs, but I could see it being interesting to plot shedding as a function of L_p3_tot keeping L_ice and N_ice constant and increasing L_liq for a few different F_rim values. Maybe I will try to do that this week.
  • TODO - Once get_ice_bound() is merged, change the code in src accordingly, and test away!
  • Finally, for catching cases when we have no particles over which to compute shedding, I have currently implemented to compute shedding if L > eps && N > eps but am unsure whether the condition should be that or L > eps || N > eps.

@rorlija1 rorlija1 self-assigned this Aug 27, 2024
@rorlija1 rorlija1 added the P3 label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (9582b2d) to head (4d08bee).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   96.89%   96.92%   +0.03%     
==========================================
  Files          41       41              
  Lines        1480     1497      +17     
==========================================
+ Hits         1434     1451      +17     
  Misses         46       46              
Components Coverage Δ
src 98.78% <100.00%> (+0.01%) ⬆️
ext 69.79% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant