-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P3 melting + F_liq #449
Open
rorlija1
wants to merge
6
commits into
main
Choose a base branch
from
ro/melting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
P3 melting + F_liq #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 96.89% 96.88% -0.01%
==========================================
Files 41 41
Lines 1480 1509 +29
==========================================
+ Hits 1434 1462 +28
- Misses 46 47 +1
|
Hi @trontrytel , just requested your review on this, but no rush since of course this is my last week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies melting for liquid fraction and adds a P3Rates struct similar to the one in Microphysics2M.
See the docs build for further explanations, and here are some notes:
get_ice_bound()
returns a constant. Also, the rest of the tests are failing because I changed the thresholds solver to allow rime density of 0 but did not change the tests to match.ice_melt
to also compute (re)freezing ofL_liq
. In Cholette (2019), the freezing rate (eq. A5 p. 578) is almost identical to the melting rate, except for a sign change and using the latent heat of sublimation, and for freezing we care about the mixed-phase particle mass contentL_p3_tot
as well as the mixed-phase particle PSD instead of only caring about ice like we do for melting. Since we switch between melting and freezing based on temperature, maybe it would be nicest to implement them both in one function?L > eps && N > eps
but am unsure whether the condition should be that orL > eps || N > eps
.