Implementing Chen 2022 Terminal Velocity Formulas into 2M scheme #144
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 97.58% 97.67% +0.08%
==========================================
Files 12 12
Lines 788 818 +30
==========================================
+ Hits 769 799 +30
Misses 19 19
☔ View full report in Codecov by Sentry. |
|
I left some small comments. I'm wondering about something. If we move the individual velocity to documentation, then mabe the bulk velocity from Chen2022 could just be defined in the 2-moment microphysics module? I think that would make more sense, sonce it can only be used with it, as we are assuming the same size distribution It would also be great to add some tests |
apoorva-thanvantri
changed the title
120: Add terminal velocity params from Chen et al 2022 r=trontrytel a=trontrytel Needed for CloudMicrophysics.jl PR:CliMA/CloudMicrophysics.jl#144 Co-authored-by: Anna Jaruga <[email protected]>
trontrytel
force-pushed
the
at/terminal_velocity_chen
branch
from
07834a8
to
ff33182
Compare
trontrytel
force-pushed
the
at/terminal_velocity_chen
branch
from
7d68ff5
to
8953b50
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
The purpose of this pull request is to add the new terminal velocity formulas for raindrops (and potentially ice particles) from Chen 2022 to the 2 Moment Cloud Microphysics Scheme.
To-do
implement formulas for ice
Content
wrote documentation page! (might need some edits)
initial implementation of formulas - still have questions/concerns on size distribution; need to edit
made plots comparing terminal velocity formulas between chen and seifert and Ogura(1 moment formula)
made unit tests