free_surface default for a DistributedGrid #232
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 32 32
Lines 1843 1843
=====================================
Misses 1843 1843 ☔ View full report in Codecov by Sentry. |
| @@ -44,7 +45,7 @@ default_free_surface(grid) = SplitExplicitFreeSurface(grid; cfl=0.7) | |||
|
|
|||
| # 70 substeps is a safe rule of thumb for an ocean at 1/4 - 1/10th of a degree | |||
| # TODO: pass the cfl and a given Δt to calculate the number of substeps? | |||
| default_free_surface(grid::TripolarGrid) = SplitExplicitFreeSurface(grid; substeps = 70) | |||
| default_free_surface(grid::Union{TripolarGrid, DistributedGrid}) = SplitExplicitFreeSurface(grid; substeps = 70) | |||
There was a problem hiding this comment.
Why not just make this always the default?
Note that this doesn't cover ImmersedBoundaryGrid but it needs to (which is done on #230)
All these changes need tests I think.
There was a problem hiding this comment.
Another comment is: a better design for this function would pass in a minimum expected time-step. Then, it could be leveraged by users who find that the default doesn't work for them (but who may not be able to automatically guess how many substeps they need --- which depends on the depth of the ocean, gravitational acceleration, the grid spacing, and the minimum expected time-step.
No description provided.