Add downgrade workflow, fix lower bounds #2078
Conversation
Sbozzolo
force-pushed
the
gb/downgrade
branch
13 times, most recently
from
3f2adb2
to
ac944fb
Compare
|
I think we can split this PR up into:
I'm happy to help peel off some pieces |
|
Removing some of the packages was needed to add the downgrade job, otherwise it was impossible to solve the version constraint (see some of the failed github actions). Also, the job is still failing, so I haven't fully figured out what needs to be done. I'd like to merge this (fixing the lower bounds) before making the new release, if possible. The lower bounds of the compats are wrong, which makes adding downgrade to other packges harder. |
I would like to merge this too, but I think I'd prefer we don't wait for the next release. I was hoping to make a release today. We can always make another quick patch release soon after. I'd like to have frequent release cycles when we have frequent delivered features/improvements, and there are a bunch in main right now. |
Sbozzolo
force-pushed
the
gb/downgrade
branch
from
ac944fb
to
8f4f8e5
Compare
I think I can fix this in the next hour or so. |
Sbozzolo
force-pushed
the
gb/downgrade
branch
4 times, most recently
from
8ab7a38
to
e507b1d
Compare
|
The downgrade tests passed. I am rebasing and this should be ready. |
Sbozzolo
force-pushed
the
gb/downgrade
branch
from
e507b1d
to
e155ef6
Compare
|
Ah, sorry, I didn't realize that #2080 would result in conflicts. I hope it's not too complicated to fix. I support merging this once it's resolved / rebased. |
The only data structure needed in OrderedDict, which is also provided by DataStructures (which is already a dependency of ClimaCore)
It is only used in one place, where it can be easily inlined
This commit adds the downgrade github action and cleans up some incorrect lower bounds.
This test was failing with
```
/home/runner/work/ClimaCore.jl/ClimaCore.jl/test/Spaces/unit_spaces.jl:58
Expression: coord_slab[slab_index(4)] == Geometry.XPoint{FT}(5)
Evaluated: XPoint(4.999999999999999) == XPoint(5.0)
```
Sbozzolo
force-pushed
the
gb/downgrade
branch
from
e155ef6
to
5b99f3f
Compare
This commit adds the downgrade github action and cleans up some incorrect lower bounds. I also removed a couple of packages that could be trivially removed.
Closes #1781