Use a Symmetric matrix in the Covariant Axis2Tensor #1828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of symmetric matrices for the Covariant Axis2Tensors.
I think that this should be all we need, and this may result in a nice improvement in our kernels that use these tensors.
I first tried to use
LinearAlgebra.Symmetric
, however, it has auplo::Char
field, and this isn't a float type and as a result does not pass thecheck_basetype(T, S)
test in our DataLayouts. So, I grabbed most of those definitions from LinearAlgebra and simply removeduplo
.I did have to widen the allowable types in
AxisTensor
.Closes #1827 (the
issymmetric
test fails on main without fixing #1827).