Replace UnrolledFunctions with UnrolledUtilities #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
approved these changes
May 3, 2024
charleskawczynski
force-pushed
the
ck/unrolled_utilities
branch
from
1eff233
to
10c07d2
Compare
charleskawczynski
force-pushed
the
ck/unrolled_utilities
branch
3 times, most recently
from
2c4f127
to
312c9c9
Compare
charleskawczynski
force-pushed
the
ck/unrolled_utilities
branch
from
c78f678
to
95268ab
Compare
charleskawczynski
force-pushed
the
ck/unrolled_utilities
branch
from
95268ab
to
42b567e
Compare
charleskawczynski
force-pushed
the
ck/unrolled_utilities
branch
from
42b567e
to
2c31e48
Compare
|
@dennisYatunin, mind taking a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dennisYatunin, I've revived this PR, and I inlined
unrolled_findonly(as this wasn't included in UnrolledUtilities, and doesn't have a Base equivalent). Can you please take a second look?