Change Ref -> tuple in broadcasting CartesianVector #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
requested review from
simonbyrne,
nefrathenrici and
dennisYatunin
simonbyrne
approved these changes
Jul 12, 2023
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 12, 2023
1366: Change Ref -> tuple in broadcasting CartesianVector r=charleskawczynski a=charleskawczynski This PR changes Ref -> tuple in broadcasting CartesianVector, since we were having allocation issues with `Ref`. Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
|
@simonbyrne, this is basically failing because: julia> [1][]
1
julia> (1,)[]
ERROR: MethodError: no method matching getindex(::Tuple{Int64})
Closest candidates are:
getindex(::Tuple, ::Int64) at tuple.jl:29
getindex(::Tuple, ::Integer) at tuple.jl:30
getindex(::Tuple, ::Colon) at tuple.jl:33
...
Stacktrace:
[1] top-level scope
@ REPL[3]:1We precisely fail in Base.@propagate_inbounds function get_node(space, scalar, ij, slabidx)
scalar[]
endShould we replace the |
|
Or define ? |
charleskawczynski
force-pushed
the
ck/ref
branch
from
85a11eb
to
a561ac5
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 13, 2023
1366: Change Ref -> tuple in broadcasting CartesianVector r=charleskawczynski a=charleskawczynski This PR changes Ref -> tuple in broadcasting CartesianVector, since we were having allocation issues with `Ref`. Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/ref
branch
from
a561ac5
to
3edb5fd
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Ref -> tuple in broadcasting CartesianVector, since we were having allocation issues with
Ref.