Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify warning in case SLEVE scale height is poorly specified, add test. #1353

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Modify warning in case SLEVE scale height is poorly specified, add test. #1353

merged 1 commit into from
Jun 28, 2023

Conversation

akshaysridhar
Copy link
Member

@akshaysridhar akshaysridhar commented Jun 27, 2023 •
edited
Loading

Modifies the warning message when decay scale parameter s is poorly specified.
Adds a test for this warning using the at-test_logs macro.

modified: src/Hypsography/Hypsography.jl
6a18955 
	modified:   test/Spaces/terrain_warp.jl
@akshaysridhar
Copy link
Member Author

akshaysridhar commented Jun 27, 2023 •
edited
Loading

@charleskawczynski I just changed this to use at-test_logs after you approved this - please take a look at the change when you can; thank you!

@akshaysridhar
Copy link
Member Author

Outcome in local test is as follows -

┌ Warning: Decay scale (s*z_top = 0.1) must be higher than max surface elevation (max(z_surface) = 0.5). Returning s = FT(0.8). Scale height is therefore s=0.8 m.
└ @ ClimaCore.Hypsography ~/Research/Codes/ClimaCore.jl/src/Hypsography/Hypsography.jl:101
┌ Warning: Decay scale (s*z_top = 0.1) must be higher than max surface elevation (max(z_surface) = 0.5). Returning s = FT(0.8). Scale height is therefore s=0.8 m.
└ @ ClimaCore.Hypsography ~/Research/Codes/ClimaCore.jl/src/Hypsography/Hypsography.jl:101
Test Summary:                           | Pass  Total  Time
Interior Mesh `Adaption`: Test Warnings |    2      2  1.0s

@akshaysridhar
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 27, 2023
@bors
Try #1353:
d328f7f
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

charleskawczynski
charleskawczynski approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've not seen @test_logs!

@akshaysridhar
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jun 28, 2023
@bors
Merge #1353
a0d35d6 
1353: Modify warning in case SLEVE scale height is poorly specified, add test.  r=akshaysridhar a=akshaysridhar

Modifies the warning message when decay scale parameter `s` is poorly specified. 
Additionally adds a test for this warning using the `at-test_logs` macro. 

Co-authored-by: Akshay Sridhar <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

Build failed:

  • lib-climacore-makie

@akshaysridhar
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a7ae37d into main Jun 28, 2023
6 checks passed
@bors bors bot deleted the as/update-warning branch June 28, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski approved these changes

@sriharshakandala sriharshakandala Awaiting requested review from sriharshakandala

Assignees
No one assigned
Labels
error message unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaysridhar @charleskawczynski