Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ifelse allocations broadcast test #1352

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Add ifelse allocations broadcast test #1352

merged 1 commit into from
Jun 28, 2023

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Jun 27, 2023 •
edited
Loading

Adds a simple test to see when ifelse() allocates when broadcasted.

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 27, 2023
@bors
Try #1352:
a0df0ae
@charleskawczynski
Copy link
Member

charleskawczynski commented Jun 27, 2023 •
edited
Loading

Thanks! This looks great, but I'm seeing unexpected passes for all of the cases!

@bors
Copy link
Contributor

bors bot commented Jun 27, 2023

try

Build failed:

@nefrathenrici
Copy link
Member Author

Thanks! This looks great, but I'm seeing unexpected passes for all of the cases!

Maybe mine is setup wrong, it looks like it's not allocating on buildkite.

@charleskawczynski
Copy link
Member

Make sure you try (from ClimaCore.jl/):

julia --project=test

julia> ]
test> dev .

to make sure your test env is configured correctly!

@nefrathenrici
Copy link
Member Author

nefrathenrici commented Jun 27, 2023 •
edited
Loading

I made sure the env was setup correctly, then included the file, but then I got allocations for the exponent tests:

Stacktrace:
 [1] macro expansion
   @ C:\Users\nathe\AppData\Local\Programs\Julia-1.8.1\share\julia\stdlib\v1.8\Test\src\Test.jl:464 [inlined]   
 [2] macro expansion
   @ C:\Users\nathe\Clima\ClimaCore.jl\test\Fields\field.jl:108 [inlined]
 [3] macro expansion
   @ C:\Users\nathe\AppData\Local\Programs\Julia-1.8.1\share\julia\stdlib\v1.8\Test\src\Test.jl:1357 [inlined]  
 [4] top-level scope
   @ C:\Users\nathe\Clima\ClimaCore.jl\test\Fields\field.jl:103
Broadcasting with ^n: Test Failed at C:\Users\nathe\Clima\ClimaCore.jl\test\Fields\field.jl:108
  Expression: p_allocated == 0
   Evaluated: 3472 == 0

This turned out to be an issue with ClimaComms - see: CliMA/ClimaComms.jl#55

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 28, 2023
@bors
Try #1352:
d95dfa6
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

try

Build failed:

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 28, 2023
@bors
Try #1352:
f888bcf
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 28, 2023
@bors
Try #1352:
cf7e36d
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

try

Build failed:

@nefrathenrici
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 28, 2023
@bors
Try #1352:
04854cb
charleskawczynski
charleskawczynski approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charleskawczynski
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f403dea into main Jun 28, 2023
@bors bors bot deleted the ne/ifelse_test branch June 28, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nefrathenrici @charleskawczynski