Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPU Thomas solver #1348

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Add GPU Thomas solver #1348

merged 1 commit into from
Jul 5, 2023

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Jun 26, 2023 •
edited
Loading

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@dennisYatunin
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 26, 2023
@bors
Try #1348:
5e6dea9
@bors
Copy link
Contributor

bors bot commented Jun 26, 2023

try

Build failed:

@dennisYatunin
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 26, 2023
@bors
Try #1348:
f0ec8c8
@bors
Copy link
Contributor

bors bot commented Jun 27, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@sriharshakandala sriharshakandala linked an issue Jun 27, 2023 that may be closed by this pull request
GPU-capable Thomas algorithm applied directly to StencilCoefs #1345
Closed
@sriharshakandala sriharshakandala marked this pull request as ready for review June 27, 2023 17:46
@dennisYatunin dennisYatunin force-pushed the sk/dy/gpu_thomas branch 2 times, most recently from d0954ed to 1d9d656 Compare June 28, 2023 23:50
@dennisYatunin
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 28, 2023
@bors
Try #1348:
10fa198
@bors
Copy link
Contributor

bors bot commented Jun 29, 2023

try

Build failed:

@dennisYatunin
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 29, 2023
@bors
Try #1348:
eff7e1a
@bors
Copy link
Contributor

bors bot commented Jun 29, 2023

try

Build failed:

@dennisYatunin
Copy link
Member

bors try

@dennisYatunin
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 29, 2023
@bors
Try #1348:
ef3479d
@bors
Copy link
Contributor

bors bot commented Jun 29, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

charleskawczynski
charleskawczynski requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make column_thomas_solve! work for Fields.ExtrudedFiniteDifferenceField and Fields.ColumnField. Let's handle this with dispatch (let's add types for these methods so it's clear what types of fields they're valid for, and so that we get better error messages), we'll need an extra method or two. Let me know if you need help.

@dennisYatunin dennisYatunin force-pushed the sk/dy/gpu_thomas branch 2 times, most recently from 3aa2f30 to 00cada7 Compare June 30, 2023 23:59
@dennisYatunin
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jul 1, 2023
@bors
Try #1348:
043ac36
@bors
Copy link
Contributor

bors bot commented Jul 1, 2023

try

Build failed:

@dennisYatunin
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jul 1, 2023
@bors
Try #1348:
0913fe6
@bors
Copy link
Contributor

bors bot commented Jul 1, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

charleskawczynski
charleskawczynski reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, nothing seems to be converging, so there seems to be a translational bug somewhere. Maybe we can add a test against the original code to identify the issue?

@charleskawczynski
Copy link
Member

New build at https://buildkite.com/clima/climaatmos-ci/builds/10949

@dennisYatunin
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 5, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 64571b5 into main Jul 5, 2023
@bors bors bot deleted the sk/dy/gpu_thomas branch July 5, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne left review comments

@charleskawczynski charleskawczynski charleskawczynski approved these changes

@dennisYatunin dennisYatunin Awaiting requested review from dennisYatunin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPU-capable Thomas algorithm applied directly to StencilCoefs
4 participants
@sriharshakandala @dennisYatunin @charleskawczynski @simonbyrne