Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly deprecate enable_threading, bump patch version #1347

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Properly deprecate enable_threading, bump patch version #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19ba14d
Properly deprecate enable_threading
charleskawczynski Jun 23, 2023
0f77ac0
Increment patch version
charleskawczynski Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ClimaCore"
uuid = "d414da3d-4745-48bb-8d80-42e94e092884"
authors = ["CliMA Contributors <[email protected]>"]
version = "0.10.41"
version = "0.10.42"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
2 changes: 1 addition & 1 deletion src/DataLayouts/DataLayouts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import Base: Base, @propagate_inbounds
import StaticArrays: SOneTo, MArray, SArray
import ClimaComms

import ..enable_threading, ..slab, ..slab_args, ..column, ..column_args, ..level
import ..slab, ..slab_args, ..column, ..column_args, ..level
export slab, column, level, IJFH, IJF, IFH, IF, VF, VIJFH, VIFH, DataF

include("struct.jl")
Expand Down
7 changes: 3 additions & 4 deletions src/interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ and running julia with `julia --nthreads=N ...`
This function is deprecated in version `0.10.42`.
Please use the ClimaComms context for threading.
"""
function enable_threading()
@warn "Use ClimaComms context for threading"
return false
end
enable_threading() = false
Base.@deprecate enable_threading() deprecated_enable_threading() false
deprecated_enable_threading() = false

"""
slab(data::AbstractData, h::Integer)
Expand Down