define fill on Fields, remove TU.FieldFromNamedTuple #1339
Conversation
|
bors r+ |
1339: define fill on Fields, remove TU.FieldFromNamedTuple r=simonbyrne a=simonbyrne It probably makes sense to define this. - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]>
|
Build failed: |
|
bors r+ |
1339: define fill on Fields, remove TU.FieldFromNamedTuple r=simonbyrne a=simonbyrne It probably makes sense to define this. - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]>
|
Build failed: |
|
bors r+ |
1339: define fill on Fields, remove TU.FieldFromNamedTuple r=simonbyrne a=simonbyrne It probably makes sense to define this. - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]>
|
Build failed: |
charleskawczynski
force-pushed
the
sb/fill
branch
from
3c94908
to
b09583a
Compare
|
bors r+ |
1339: define fill on Fields, remove TU.FieldFromNamedTuple r=charleskawczynski a=simonbyrne It probably makes sense to define this. - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]> Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
charleskawczynski
force-pushed
the
sb/fill
branch
from
b09583a
to
133272f
Compare
|
@simonbyrne, I rebased and fixed two more failing tests, but it's now failing in the SEM operator perf tests, due to scalar indexing (during setup). I'm fine with allowing it, but scalar indexing should be disabled for the actual perf tests. |
|
bors try |
tryBuild failed: |
|
Good catch, we should probably define a proper |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
It probably makes sense to define this.