allow broadcasting over horizontal spaces #1332
Conversation
There was a problem hiding this comment.
This looks great! I'm realizing now that the test I included exercises the correct broadcast parts, but there's no test. Also: can you confirm that this is equivalent behavior to the point-domain broadcasting?
I.e., a single point broadcasts over the entire column, or entire domain
|
i don't have a good test for that yet... |
|
This PR should basically allow us to do explicit held suarez and aqua planet runs (right now we are limited to baroclinic wave, which excludes vertical diffusion). |
simonbyrne
force-pushed
the
sb/broadcast-horizontal
branch
from
4b8ab77
to
d1bb0c5
Compare
|
bors r+ |
1332: allow broadcasting over horizontal spaces r=simonbyrne a=simonbyrne Fixes #1331. - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]>
|
Build failed: |
|
bors r+ |
1332: allow broadcasting over horizontal spaces r=simonbyrne a=simonbyrne Fixes #1331. - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]>
|
Build failed: |
simonbyrne
force-pushed
the
sb/broadcast-horizontal
branch
from
d1bb0c5
to
cceb35f
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Fixes #1331.