Skip to content

Commit

Permalink
Merge #901
Browse files Browse the repository at this point in the history
901: Remove reviewdog r=simonbyrne a=charleskawczynski

I'm afraid I find review dog to be really noisy. It can basically ruin the landing page of PRs if someone forgets to format before pushing / forgetting to start with a draft PR (e.g., #887). Am I alone? 🐶

Co-authored-by: Charles Kawczynski <[email protected]>
  • Loading branch information
bors[bot] and charleskawczynski committed Jun 23, 2023
2 parents 77d13a8 + 1f440c9 commit 5d7be91
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/JuliaFormatter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,6 @@ jobs:
run: |
julia --color=yes --project=.dev .dev/climaformat.jl --verbose .
- name: Suggester
uses: reviewdog/action-suggester@v1
if: github.event.pull_request.draft == false
with:
tool_name: JuliaFormatter
level: error
fail_on_error: true

- name: Check formatting diff
if: steps.filter.outputs.julia_file_change == 'true'
run: |
Expand Down

0 comments on commit 5d7be91

Please sign in to comment.