Skip to content

Commit

Permalink
Merge #1321
Browse files Browse the repository at this point in the history
1321: Run all unit tests in buildkite r=charleskawczynski a=charleskawczynski

This PR:
 - moves all of the unit tests into buildkite.
 - Deletes the `test/gpu/device.jl` file, since it's from a deprecated module
 - Moves `test/gpu/data.jl → test/DataLayouts/cuda.jl`
 - Attempts to improve the grouping and labeling of the tests in the buildkite pipeline

I've also incorporated #1319.

This is a pretty big step towards #837. Making bors not depend on GHA would effectively close the issue.

Co-authored-by: Charles Kawczynski <[email protected]>
  • Loading branch information
bors[bot] and charleskawczynski authored Jun 16, 2023
2 parents 534c678 + b164a82 commit 046c63f
Show file tree
Hide file tree
Showing 12 changed files with 572 additions and 358 deletions.
777 changes: 568 additions & 209 deletions .buildkite/pipeline.yml

Large diffs are not rendered by default.

42 changes: 0 additions & 42 deletions perf/allocs.jl

This file was deleted.

18 changes: 0 additions & 18 deletions perf/allocs_per_case.jl

This file was deleted.

File renamed without changes.
15 changes: 0 additions & 15 deletions test/Limiters/distributed.jl

This file was deleted.

4 changes: 2 additions & 2 deletions test/Operators/finitedifference/column_benchmark_utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -414,8 +414,8 @@ end

function test_results(t_ave)
# If these tests fail, just update the numbers (or the
# buffer) so long its not an agregious regression.
buffer = 1.7
# buffer) so long its not an egregious regression.
buffer = 2
ns = 1
μs = 10^3
@test t_ave[(:no_h_space, op_GradientF2C!, :none)] < 559.8423*ns*buffer
Expand Down
17 changes: 0 additions & 17 deletions test/Operators/spectralelement/run_sphere_geometry_distributed.jl

This file was deleted.

File renamed without changes.
18 changes: 0 additions & 18 deletions test/Spaces/distributed.jl

This file was deleted.

13 changes: 0 additions & 13 deletions test/Topologies/distributed.jl

This file was deleted.

21 changes: 0 additions & 21 deletions test/gpu/device.jl

This file was deleted.

5 changes: 2 additions & 3 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Stacktrace:
[1] pkgerror(msg::String)
=#
if !Sys.iswindows()
@safetestset "Recursive" begin @time include("recursive.jl") end
@safetestset "Recursive" begin @time include("RecursiveApply/recursive_apply.jl") end
@safetestset "PlusHalf" begin @time include("Utilities/plushalf.jl") end

@safetestset "DataLayouts 0D" begin @time include("DataLayouts/data0d.jl") end
Expand Down Expand Up @@ -99,8 +99,7 @@ if !Sys.iswindows()
end
if "CUDA" in ARGS
@safetestset "GPU - cuda" begin @time include("gpu/cuda.jl") end
@safetestset "GPU - data" begin @time include("gpu/data.jl") end
@safetestset "GPU - device" begin @time include("gpu/device.jl") end
@safetestset "GPU - data" begin @time include("test/DataLayouts/cuda.jl") end
@safetestset "Spaces - serial CUDA DSS" begin @time include("Spaces/ddss1.jl") end
@safetestset "Spaces - serial CUDA DSS on CubedSphere" begin @time include("Spaces/ddss1_cs.jl") end
@safetestset "Operators - spectral element CUDA" begin @time include("Operators/spectralelement/rectilinear_cuda.jl") end
Expand Down

0 comments on commit 046c63f

Please sign in to comment.