Make MPI restart test more robust #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/fixy
branch
2 times, most recently
from
d9db8dd
to
9dcafb6
Compare
Sometimes the shared filesystem is slow and the folder is properly not synced across MPI processes. This commit adds an extra check to ensure that all the MPI processes see the tmpfolder before moving forward.
szy21
approved these changes
Nov 4, 2024
| # Sometimes the shared filesystem doesn't work properly | ||
| # and the folder is not synced across MPI processes. | ||
| # Let's add an additional check here. | ||
| maybe_wait_filesystem(comms_ctx, output_loc) |
There was a problem hiding this comment.
What does maybe_wait_filesystem do exactly?
There was a problem hiding this comment.
It checks that all the MPI processes see that the temporary folder was created. If they don't agree, it waits a tiny bit and check again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the shared filesystem is slow and the folder is properly not synced across MPI processes. This commit adds an extra check to ensure that all the MPI processes see the tmpfolder before moving forward.