Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix indivisible reduction periods warning #3408

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix indivisible reduction periods warning #3408

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f0f000
fix indivisible reduction periods warning
haakon-e Oct 29, 2024
63815a1
format
haakon-e Oct 29, 2024
2dfe0b6
format 2
haakon-e Oct 29, 2024
d1833fa
warning wording
haakon-e Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/solver/type_getters.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,10 @@ function get_simulation(config::AtmosConfig)
x -> !CA.isdivisible(checkpoint_frequency, x),
periods_reductions,
)
@warn "Some accumulated diagnostics might not be evenly divisible by the checkpointing frequency ($(CA.promote_period(checkpoint_frequency)))"
accum_str =
join(CA.promote_period.(collect(periods_reductions)), ", ")
checkpt_str = CA.promote_period(checkpoint_frequency)
@warn "The checkpointing frequency (dt_save_state_to_disk = $checkpt_str) should be an integer multiple of all diagnostics accumulation periods ($accum_str) to simulations can be safely restarted from any checkpoint"
end
end
else
Expand Down
Loading