Try using purely vertical spaces for column configurations #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/specialize_column
branch
from
ef4be42
to
52d78ba
Compare
charleskawczynski
force-pushed
the
ck/specialize_column
branch
from
52d78ba
to
6a8a2e9
Compare
|
I also would like to see this. Note that this will require also fixing all the postprocessing (that assumed that columns were actually boxes) and fixing this: CliMA/ClimaCore.jl#2032 |
Co-authored-by: Akshay Sridhar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at calibrations, I realized that we seem to always generate
VIJFHdatalayouts, even for column cases. Our CPU and GPU code paths for each datalayout is split so that we can optimize kernels specifically for those datalayouts. So, we should probably allow these spaces to be flexible so that we get the most out of the true datalayout.