Add function barrier to coriolis computation #3289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function barrier to the computation of the coriolis force, which I noticed captures a variable (
f
):Due to this, users cannot copy-paste this into the REPL. I've also refactored that code to use
map
with an assertion so that it can be copy-pasted into the REPL. I did not yet apply these changes to the deep atmosphere, because we need to somehow avoid capturingglobal_geom
.