Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function barrier to coriolis computation #3289

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

charleskawczynski
Copy link
Member

This PR adds a function barrier to the computation of the coriolis force, which I noticed captures a variable (f):

        f = CAP.f_plane_coriolis_frequency(params)
        coriolis_f_plane(coord) = Geometry.WVector(f)
        ᶜf³ = @. CT3(coriolis_f_plane(ᶜcoord))
        ᶠf¹² = nothing

Due to this, users cannot copy-paste this into the REPL. I've also refactored that code to use map with an assertion so that it can be copy-pasted into the REPL. I did not yet apply these changes to the deep atmosphere, because we need to somehow avoid capturing global_geom.

src/cache/cache.jl Outdated Show resolved Hide resolved
@charleskawczynski
Copy link
Member Author

I thought this merged and accidentally pushed to this branch.. Need to reapply..

@charleskawczynski charleskawczynski added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 11be7a8 Sep 13, 2024
14 of 16 checks passed
@charleskawczynski charleskawczynski deleted the ck/inference2 branch September 13, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants