Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rrtmgp #3264

Merged
merged 1 commit into from
Sep 9, 2024
Merged

update rrtmgp #3264

merged 1 commit into from
Sep 9, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Aug 24, 2024

Closes #3219
Closes #3265
Closes #3283

Purpose

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 force-pushed the zs/up_rrtmgp branch 4 times, most recently from ae9c695 to 401a495 Compare August 27, 2024 00:35
src/callbacks/callbacks.jl Outdated Show resolved Hide resolved
@szy21 szy21 force-pushed the zs/up_rrtmgp branch 3 times, most recently from 1aa4dd5 to 696b0b0 Compare August 27, 2024 17:51
@szy21 szy21 marked this pull request as ready for review August 27, 2024 17:52
@szy21 szy21 requested a review from Sbozzolo August 27, 2024 19:56
@szy21
Copy link
Member Author

szy21 commented Aug 27, 2024

I'll do more test and release rrtmgp before this, but @Sbozzolo Could you take a look at the code change?

@szy21 szy21 force-pushed the zs/up_rrtmgp branch 7 times, most recently from 722ed88 to 8a32148 Compare August 28, 2024 18:16
@szy21 szy21 marked this pull request as draft August 28, 2024 18:19
@szy21 szy21 force-pushed the zs/up_rrtmgp branch 5 times, most recently from 82d6994 to d57a981 Compare August 28, 2024 22:54
@szy21 szy21 force-pushed the zs/up_rrtmgp branch 8 times, most recently from 817de5f to 1723918 Compare August 30, 2024 21:37
@Sbozzolo
Copy link
Member

Sbozzolo commented Sep 1, 2024

Please, remove Pkg from the dependencies before merging this.

@szy21 szy21 force-pushed the zs/up_rrtmgp branch 9 times, most recently from 8c5cd72 to fe3327b Compare September 9, 2024 06:03
@szy21 szy21 marked this pull request as ready for review September 9, 2024 06:03
@szy21 szy21 force-pushed the zs/up_rrtmgp branch 2 times, most recently from 816f598 to 69c5bd2 Compare September 9, 2024 06:06
@szy21 szy21 enabled auto-merge September 9, 2024 06:54
@szy21 szy21 added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 6c7cf86 Sep 9, 2024
12 of 16 checks passed
@szy21 szy21 deleted the zs/up_rrtmgp branch September 9, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClimaAtmos should not use data defined in the tests for RRTGMP
2 participants