Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate calibration pipeline into atmos #2895

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Integrate calibration pipeline into atmos #2895

merged 1 commit into from
Jul 5, 2024

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Apr 11, 2024 •
edited
Loading

This PR adds the framework for reproducible calibration experiments, starting with one example experiment.

calibration/README.md provides an overview. Most of the actual code is in ClimaCalibrate

Content

calibration/model_interface.jl: Model interface hooks for CalibrateAtmos. This will be used in every atmos calibration.
test/calibration_interface.jl: Basic tests for the model interface file.
calibration/experiments: Folder containing subfolders of calibration experiments. Currently only contains sphere_held_suarez_rhoe_equilmoist

sphere_held_suarez_rhoe_equilmoist/

  • experiment_config.yml: Stores filepaths for calibration artifacts and other configuration data
  • model_config.yml: Atmos yaml config for the calibration
  • pipeline.sbatch: Script to run calibration experiment on central
  • observation_map.jl: Code to process model output into observation space
  • postprocessing.jl: Plotting script
  • prior.toml: Prior distribution file

@AlexisRenchon AlexisRenchon mentioned this pull request May 22, 2024
Merged
@nefrathenrici nefrathenrici force-pushed the ne/calibrate branch 2 times, most recently from 16c9a61 to 9ea6670 Compare May 23, 2024 16:54
@nefrathenrici nefrathenrici marked this pull request as ready for review May 23, 2024 17:37
@Sbozzolo
Copy link
Member

I am not too familiar with the calibration pipeline, so it will take me a little bit of time to understand and properly review this PR.

@Sbozzolo
Copy link
Member

What is the ultimate intent of this PR? Is it to test that things work? To teach people how to do calibration? Other reasons?

@costachris costachris mentioned this pull request Jun 7, 2024
Closed
@nefrathenrici nefrathenrici force-pushed the ne/calibrate branch 2 times, most recently from 0ed762c to bf8cdc3 Compare June 12, 2024 04:00
Sbozzolo
Sbozzolo reviewed Jul 2, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Project.toml Show resolved Hide resolved
calibration/experiments/sphere_held_suarez_rhoe_equilmoist/Manifest.toml Outdated Show resolved Hide resolved
calibration/experiments/sphere_held_suarez_rhoe_equilmoist/model_config.yml Show resolved Hide resolved
calibration/experiments/sphere_held_suarez_rhoe_equilmoist/postprocessing.jl Outdated Show resolved Hide resolved
calibration/model_interface.jl Outdated Show resolved Hide resolved
calibration/test/Manifest.toml Outdated Show resolved Hide resolved
calibration/test/e2e_test.jl Show resolved Hide resolved
calibration/test/e2e_test.jl Outdated Show resolved Hide resolved
@nefrathenrici nefrathenrici force-pushed the ne/calibrate branch 2 times, most recently from d8eeb14 to bb9d6d1 Compare July 3, 2024 19:49
Sbozzolo
Sbozzolo reviewed Jul 3, 2024
View reviewed changes
.github/workflows/calibration_test.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
calibration/experiments/sphere_held_suarez_rhoe_equilmoist/model_interface.jl Outdated Show resolved Hide resolved
calibration/experiments/sphere_held_suarez_rhoe_equilmoist/pipeline.sbatch Outdated Show resolved Hide resolved
calibration/test/Manifest.toml Outdated Show resolved Hide resolved
calibration/test/Project.toml Show resolved Hide resolved
@nefrathenrici nefrathenrici force-pushed the ne/calibrate branch 2 times, most recently from 4f7138d to 5d7cb69 Compare July 4, 2024 00:06
@nefrathenrici nefrathenrici force-pushed the ne/calibrate branch 3 times, most recently from 1c6a243 to 3cffe76 Compare July 5, 2024 01:18
@nefrathenrici nefrathenrici force-pushed the ne/calibrate branch 2 times, most recently from ec0c07c to c9eb78c Compare July 5, 2024 02:08
@nefrathenrici nefrathenrici added this pull request to the merge queue Jul 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 5, 2024
@nefrathenrici nefrathenrici added this pull request to the merge queue Jul 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 5, 2024
@nefrathenrici nefrathenrici added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit fd2fcf2 Jul 5, 2024
12 of 14 checks passed
@nefrathenrici nefrathenrici deleted the ne/calibrate branch July 5, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odunbar odunbar odunbar left review comments

@charleskawczynski charleskawczynski charleskawczynski approved these changes

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nefrathenrici @Sbozzolo @charleskawczynski @odunbar