Add an interface for debugging the implicit solver Jacobian #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
force-pushed
the
dy/jacobian_debugging
branch
6 times, most recently
from
8f212a8
to
75db91e
Compare
dennisYatunin
added this to the O1.4.3 Implicit solver for full atmosphere model milestone
dennisYatunin
force-pushed
the
dy/jacobian_debugging
branch
23 times, most recently
from
8e230c6
to
9836897
Compare
dennisYatunin
force-pushed
the
dy/jacobian_debugging
branch
5 times, most recently
from
1c2a491
to
5aa9095
Compare
dennisYatunin
force-pushed
the
dy/jacobian_debugging
branch
from
5aa9095
to
26e1c53
Compare
dennisYatunin
force-pushed
the
dy/jacobian_debugging
branch
5 times, most recently
from
4bcfc65
to
1dc4033
Compare
dennisYatunin
force-pushed
the
dy/jacobian_debugging
branch
17 times, most recently
from
e7c3e2e
to
f5d4734
Compare
dennisYatunin
force-pushed
the
dy/jacobian_debugging
branch
from
f5d4734
to
856dec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR splits the
ImplicitEquationJacobianinto anApproxJacobian, anExactJacobian, and aDebugJacobian. The first option is the Jacobian approximation we've been using until now, while the second option is an exact Jacobian computed usingForwardDiffand inverted using column-wise LU decomposition. The third option can act like either of the other two, and it checks the approximation against the exact computation whenever the exact Jacobian is updated.This PR also gets rid of some outdated code related to
OrdinaryDiffEqin order to simplify the interface design.To-do
Add some working examples to CI.
Content