Update to new implicit solver interface #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
4 times, most recently
from
f89e65f
to
957c891
Compare
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
from
957c891
to
4c97cc1
Compare
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
4 times, most recently
from
8c7465d
to
8759ffa
Compare
|
bors try |
tryBuild failed: |
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
7 times, most recently
from
a302b55
to
89a45fd
Compare
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
9 times, most recently
from
722f800
to
0179e9c
Compare
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
2 times, most recently
from
435c248
to
30ddcec
Compare
|
bors r+ |
|
bors cancel |
|
Canceled. |
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
3 times, most recently
from
728f90e
to
08ea344
Compare
dennisYatunin
changed the title
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
3 times, most recently
from
f42355b
to
7f91e2e
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 18, 2023
2044: Update to new implicit solver interface r=dennisYatunin a=dennisYatunin Co-authored-by: Dennis Yatunin <[email protected]>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 18, 2023
2044: Update to new implicit solver interface r=szy21 a=dennisYatunin Co-authored-by: Dennis Yatunin <[email protected]>
|
Build failed: |
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
2 times, most recently
from
177f417
to
95fdd0a
Compare
dennisYatunin
force-pushed
the
dy/try_new_interface
branch
from
95fdd0a
to
40cae18
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Updates ClimaAtmos to use the new implicit solver interface provided in
ClimaCore.MatrixFields(CliMA/ClimaCore.jl#1326, CliMA/ClimaCore.jl#1399, and CliMA/ClimaCore.jl#1436).Content
wfact.jlandlinsolve.jlwithimplicit_solver.jl. Most of the code fromwfact.jlhas been rewritten using the newFieldNameandFieldMatrixinfrastructure, while most of the code fromlinsolve.jlhas been moved into the definition ofFieldMatrixSolverinClimaCore.u₃to useAxisTensors andAdjointAxisTensors. (We were previously replacing these derivatives with similar derivatives with respect tou₃_data, which made the code unnecessarily complicated.)ImplicitEquationJacobianobject. (This was formerly calledSchurComplementW, but it needed to be renamed because we will not always use the "Schur complement solve" algorithm in the future.) Simplify and update the comments in thewfact!function to reflect the new code.test/implicit/debugging_tools.jl. Although this still isn't a unit test, as the code is not currently modular enough to write a proper test, it can be very helpful when debugging the matrix blocks in theImplicitEquationJacobian.