Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve f_consume_item_sum and f_has_items_sum, use it more #77791

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve f_consume_item_sum and f_has_items_sum, use it more #77791

wants to merge 3 commits into from

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Finally fix #74451

Describe the solution

better code, smarter code, now it works in PICKUP_RANGE
use it in two quests that i was asked to

Testing

Running it as eoc works correctly, see no reason it should not work in quests

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Missions Quests and missions [C++] Changes (can be) made in C++. Previously named `Code` EOC: Effects On Condition Anything concerning Effects On Condition <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 12, 2024
Night-Pryanik
Night-Pryanik reviewed Nov 13, 2024
View reviewed changes
src/npctalk.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Night-Pryanik Night-Pryanik Night-Pryanik left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce extension of u_has_item that allows items in the vicinity
2 participants
@GuardianDll @Night-Pryanik