[Xedra Evolved/Dinomod] You can drain dinosaur's ruach #77736
Merged
+27
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
json-styled
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Xedra Evolved/Dinomod] You can drain dinosaur's ruach"
Purpose of change
Fixes #77731
Describe the solution
Add a dummy EoC into the animal section of the ruach-drain EoC. If you just have XE, it does nothing. If you have DinoMod, it triggers and counts dinos as animal-tier for ruach draining.
I also noticed that the EoC wasn't checking that animals did not have the ZOMBIE species, so I added that (since zombies usually have their base species and the ZOMBIE species too)
Describe alternatives you've considered
Close as not a bug because dinosaurs do not have souls.
Testing
If you have DinoMod installed, you can drain dinosaurs' ruach.
If you don't have DinoMod installed, everything still works.
Additional context