Reserve space for vectors before allocating in a loop. #77728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Pre-allocating saves doing multiple allocations when we know exactly what size structure we need.
Describe the solution
Manually search through the code base for all
push_back
and reserve space if applicable.Describe alternatives you've considered
clang-tidy has a lint for this, but I don't really understand how it's configured for this project plus it's configured for linux. It was easier to do a find than to try and mess with the build settings.
Testing
Ran the game before and after. No noticeable performance changes. There are no functionality changes, so nothing should break.
Additional context