Camp crafting uses the normal crafting GUI

[RenechCDDA]

Summary

Interface "Camp crafting uses the normal crafting GUI"

Purpose of change

Camp crafting is problematic in many ways. Accessing the recipes, manipulating them, seeing if they're available, etc.

We have a perfectly good crafting GUI already, why not use it?

Describe the solution

Use the existing crafting GUI.

We shove all the recipes and proficiencies from our camp's NPCs into a dummy, give them access to the camp inventory, and put them into the crafting window. We wait for the return value and instead of doing a normal crafting activity we craft like camps always used to, by off-mapping a chosen NPC.

Essentially we are borrowing the crafting GUI, with a few little changes to make it work for us.

Describe alternatives you've considered

Making the mission window searchable/filterable :^)

Testing

DRAFT

2024-11-09.19-46-39.mp4

The draft as posted does not work (inventory is not properly tallied, somehow) and it does not do anything with the recipe selected in the crafting window.

Additional context

Known issues:
The flow of recipe selection --> crafter selection is maybe not ideal

Can't see kcal display until after you select a recipe

Descriptions for camp-provided recipes are still loaded and sent for translation, but we don't use them

[PatrikLundell]

Looks like a very intriguing idea, and I really hope it's successful. It would be a major improvement to base camp crafting.

And now comes the downer section with issues that will have to be dealt with at the tail end (view this as a reminder, rather than mistrust of the OP's abilities):

• There's a small number of recipes available to companions only for base camps. As far as I know they all use the drop hammer built in some base camps and in the workshop expansions, but there may be additional ones. They'd need to be dealt with in some way, with the easiest one probably being to make them available to everyone (i.e. not companion only), and make them available through either skill levels or a book.
• Make all functionality for the base camp (including expansions) available, not only regular tools and material. I think that would involve pseudo tools only, but I may be wrong, and it may already have been dealt with.
• Get rid of all the recipe couplings of base camps and expansions as they're no longer used. That's just a cleanup thing, but there may be a need to review construction mission texts and possibly base camp setup as well, to get rid of obsolete references, so it might be a bit more work than it seems initially.

Edit:
I believe the drop hammer only exists as a pseudo tool currently, so it may have to be made into e.g. an appliance to work as a regular tool as well. It might be a good idea to deal with this special case as a separate PR (and not necessarily by the same author).

[RenechCDDA]

My overall plan at this time was to move basecamp-specific recipes to their own crafting category, since otherwise they'll be very difficult to find.

I don't see a need to make (e.g.) drop hammer recipes generally available, they can still be provided by the basecamp expansions. If anything I wanted to expand on that - the expansions being able to provide access to recipes is a good thing.

One thing currently missing is the calorie cost display for crafting, I don't know how to deal with that. Maybe as a final query before you the mission starts.

[PatrikLundell]

I disagree with you regarding expansion specific recipes, as my preference is to make bases and expansions optional, but I don't disagree violently with it.

If you've got trouble with calories you've probably also go problems with time, as the time given for normal crafting is work time, while the base camp craft time is given in calendar time, and if you've figured out how to intervene in the display of things to show one you've probably done most of the work for the other, as calendar time is derived from work time and calories from calendar time and exercise level.
Also note that both of these are modified by the number of people involved (as the number of time off periods can change a by up to one for each additional person assigned).

[RenechCDDA]

This is mostly working now, except batch selection is broken. I think I just missed a call to availability so that should be easy to squash. Batch was fixed, just as simple as I thought.

Translations I think will be dealt with by simply removing them.

Not aware of any other huge issues, but there may be problems found once it gets some general testing.

[RenechCDDA]

Ehhh translations look like it won't be so simple because we want to keep translations for the expansions, but discard them only for recipes. Both are loaded as recipe_group, so it's not simple.

I guess I can kick that can down the road (to maybe someone else) and mark this ready for review, huh? Let's see if it blows up.

[Zireael07]

Finally!