Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize all walls: Part 2 #77567

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Conversation

Milopetilo
Copy link
Contributor

@Milopetilo Milopetilo commented Nov 3, 2024

Summary

None

Purpose of change

Continue on from #77459.
Also closes #77676

Describe the solution

Change the palettes and symbols in mapgen.

Describe alternatives you've considered

Testing

Game loads, walking through town most things seem as they should be.

Additional context

This part contains names starting with h-p.
There might be some mismatching walls in places that sometimes use palettes, such as office towers, since I haven't changed those yet.
Draft until #77583 is merged

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Nov 3, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 3, 2024
@Maleclypse
Copy link
Member

I have concerns. Should office towers be using parametrized walls or skyscrapers? Do they now include adobe walls? Are these external walls or internal only? What am I missing here?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 4, 2024
@Milopetilo
Copy link
Contributor Author

You're right, I should've maybe put a bit more thought into what all the walls could turn into. I'll draft this for now while I address this.

@Milopetilo Milopetilo marked this pull request as draft November 4, 2024 15:01
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 8, 2024
@Milopetilo Milopetilo marked this pull request as ready for review November 10, 2024 18:17
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 10, 2024
@Maleclypse Maleclypse merged commit a987dd7 into CleverRaven:master Nov 11, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Craft Shop has stools for walls
2 participants