Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Add two magical rings #76561

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Sep 20, 2024

Summary

Mods "[Magiclysm] Add two magical rings"

Purpose of change

Had some ideas.

Describe the solution

Add two rings:

  • Ring of Fire Protection: reduces fire damage by 50% and prevents you from being set on fire.
  • Ring of Flying: Lets you fly for 15 minutes once per day and prevents fall damage at all times.

Also adds the Crimsonite material, based on the Japanese legendary metal hihi'irokane. Crimonsite isn't particularly tough but is essentially fireproof, so you need magic to work it at all.

Describe alternatives you've considered

Testing

Spawned a demon spider and had it attack me, then threw an incendiary grenade, stepped into a raging fire, and stepped out. Was not set on fire, did not die (though took a ton of damage).

Activated the ring of flying and waited in the air. Effect ended, took no damage from the fall.

Additional context

I was going to add rings of fire protection as a rare spawn in fire stations (firefighers would absolutely want some), but fire stations don't use itemgroups for their loot so that's not possible.

@Standing-Storm Standing-Storm marked this pull request as draft September 20, 2024 02:09
@Standing-Storm Standing-Storm marked this pull request as ready for review September 20, 2024 02:31
@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels Sep 20, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 20, 2024
@Standing-Storm Standing-Storm marked this pull request as draft September 20, 2024 04:05
@Psithief
Copy link
Contributor

As a matter of convenience for the user of your flying ring, is it feasible to add a warning message to the wearer that the effect is waning?

@Standing-Storm
Copy link
Contributor Author

That would make it unique compared to other magical buffs, none of which have specific warnings, but that is the reason why I included the prevention of fall damage parameter--as long as you're still wearing the ring, if you fall you won't take damage.

Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A crimsonite ring with a dappled pattern that protects you from fire.
  • An ingot of crimsonite. About 3cm by 7cm by 12cm in size, ready to be used for various blacksmithing tasks.
  • Crimsonite
  • crimsonite ingot
  • crimsonite ingots

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Standing-Storm Standing-Storm marked this pull request as ready for review September 20, 2024 14:45
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants