Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit throwing practice tools #76492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bloodbowel
Copy link
Contributor

Summary

Features "Adds throwing practice tools"

Purpose of change

I noticed a while ago that throwing practice does not include flaking rocks.

Describe the solution

I decided to add them, and a couple of other common items that could be used. The full list is:
1.flaking rock
2.pebble
3.brick
4.wood block
5.barb wired baseball (since you have a baseball)
6.lawn dart
7.weighted dart (since I added the lawn dart)

Describe alternatives you've considered

If you think anything should be added or removed, comment. Also I was wondering about adding irregularly shaped common objects like chunks of steel. You might smash something and grab a piece if you're holed up somewhere surrounded by zombies. Pretty common thing in my early games.

Testing

Tested in debug mode on my computer.

Additional context

throwing

@bloodbowel bloodbowel changed the title add ranged practice tools Add throwing practice tools Sep 17, 2024
@github-actions github-actions bot added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 17, 2024
@RenechCDDA
Copy link
Member

The pebble's too small to properly practice with, it's really not intended for throwing.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 17, 2024
@bloodbowel
Copy link
Contributor Author

bloodbowel commented Sep 18, 2024

The pebble's too small to properly practice with, it's really not intended for throwing.

I thought that too, but it already lets you use a marble, ball bearing, and dice which are about the same size, so I included it. They never seemed right to me. What do you think of removing the other three?

@RenechCDDA
Copy link
Member

Marble and dice are right out IMO

Ball bearings can be of any size, and ours seems to be really small so you can nix that too.

@bloodbowel
Copy link
Contributor Author

I removed them. Should I actually remove them in a separate pull request for clarity? Or is it fine to do here?

@RenechCDDA
Copy link
Member

I think it's fine to do it all here. You're touching the same recipe, so all this changes are highly related. If you want, you could change the title to something like "Audit throwing practice tools" so it's that tiny tiny bit more accurate. Not a big deal though.

@bloodbowel bloodbowel changed the title Add throwing practice tools Audit throwing practice tools Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants