Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bombastic Perks] Two gun-related perks #76487

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Sep 16, 2024

Summary

None

Purpose of change

Little revolver-related perk that i thought about

Describe the solution

Add perk, add required infra
Also added second perk, that benefits .22 guns

Testing

image
image
test of weakpoint enchantment:
no weakpoint enchantment
image
with wp enchantment (numbers are inflated for test purposes)
image
no AP and AP enchantment applied
image

Additional context

Also thought about perk that gives bonuses for using .22, as a tribute to Holli

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mods: Bombastic Perks json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 16, 2024
@TheShadowFerret
Copy link
Contributor

TheShadowFerret commented Sep 16, 2024

Also thought about perk that gives bonuses for using .22, as a tribute to Holli

That does what? +AP 🤔?

@GuardianDll
Copy link
Member Author

> That does what? +AP 🤔?

honesly i'd like something more interesting, more engaging, not flat bonuses
but my brain is smol and fails me to make something interesting
armor pen could work

@Holli-Git
Copy link
Contributor

honesly i'd like something more interesting, more engaging, not flat bonuses but my brain is smol and fails me to make something interesting armor pen could work

Make it "bounce around the targets internals" (stun/extra bleed)
Give it the best stopping power (knockdown on hit)
Tactical tininess (make it much more likely to hit weakpoints)
Low power let down (All shots do 20% less damage, with a 20% chance to deal double/triple damage)

@GuardianDll
Copy link
Member Author

when i meant "something more engaging" i mean it in literal sense: "make a headshot to deal 2x damage" or stuff like this, something that gonna force player to make decisions: do i want to continue and increase the score, or i'll better retreat?

Your ideas are cool tho, i may implement them

@Holli-Git
Copy link
Contributor

Your ideas are cool tho, i may implement them

Yeah that'd also be a nice. An issue with .22 LR is that it doesn't deal crits because it doesn't cross a damage threshold

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions Monsters Monsters both friendly and unfriendly. Mechanics: Enchantments / Spells Enchantments and spells labels Sep 17, 2024
@GuardianDll GuardianDll changed the title [Bombastic Perks] Revolvers are cool [Bombastic Perks] Two gun-related perks Sep 18, 2024
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Sep 18, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 18, 2024
@Holli-Git
Copy link
Contributor

I apologize for this unsolicited name suggestion but "Rimfire Rebel" has been stuck in my brain

@TheShadowFerret
Copy link
Contributor

I don't think altering vanilla weakpoints for mod content is considered kosher 🤔

@GuardianDll
Copy link
Member Author

I didn't alter them tho, i added new field, it may be used later for different purposes

Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Rimfire Rebel

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Maddremor
Copy link
Contributor

Looks great! I wish there was some excuse to have a 22 revolver with the OLD_GUN tag so one could really triple down on boosting something silly with perks, but using a modern 22 revolver will have to do.

@GuardianDll
Copy link
Member Author

just add some revolver in vanilla, that fit our inclusion criteria, that can be considered OLD_GUN in the mod, and here you have it

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 24, 2024
@Maleclypse Maleclypse merged commit 39eabf6 into CleverRaven:master Sep 26, 2024
21 of 27 checks passed
@GuardianDll GuardianDll deleted the revolvlelelv branch September 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods: Bombastic Perks Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants