Gun mods + spawns

[Seb-The-SamMarten]

Summary

Content "2 new gunmods + added to spawn pool"

Purpose of change

To help broaden the selection of gunmods, since there's not that many. (Especially for some specific slots, but those will come later. Maybe.)

Describe the solution

Added 2 mods.
"Big Brass Catcher"; Twice the size, twice the capacity, made of canvas instead of cotton.
"Offset Grip"; An angled grip for use on the side rail slot, giving the option of a forward grip to guns with integrated bipods, or who otherwise have no underbarrel.

Describe alternatives you've considered

None, as it's new content.

Testing

Trial and error, and help from the #mod-development channel on Discord. (Special thanks to GuardianDll and Holli.)

Additional context

Any values within are more than subject to feedback and change. This is my first go at this, so all of my numbers are guesstimations based on other things that already existed.

[Seb-The-SamMarten]

Numbers tweaked based on feedback, and blacklists for other grip mods added to prevent nonsensical grip-stacking.

[Seb-The-SamMarten]

Some more fixes for code/spacing errors the bot caught. Whoops.

[Seb-The-SamMarten]

Linted the offset_rail code since the bot had an issue with it.

[SirPendrak]

Shouldnt the blacklist include other underbarrel grips, instead of "main-hand" grips, near the trigger?

So, "grip", "grip_mod", "wooden_grip", "modern_handguard".
I have no idea about "bipod_handguard" and "bipod_handguard_deployed"

[Seb-The-SamMarten]

Right. Sorry, I looked at the grip.json like a dingus. The bipods need to be allowed to have it, as it was the main point of the grip was to give access to guns that have their under barrel slot locked off. Though I do think it needs to blacklist the underbarrel weapons as well. The crossbow and the shotgun. I'll do that next time I'm on my PC.

…

On Sat, Sep 14, 2024, 4:48 AM SirPendrak ***@***.***> wrote: Shouldnt the blacklist include other underbarrel grips, instead of "main-hand" grips, near the trigger? So, "grip", "grip_mod", "wooden_grip", "modern_handguard". I have no idea about "bipod_handguard" and "bipod_handguard_deployed" — Reply to this email directly, view it on GitHub <#76416 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BLI5VTP25SCJFTTMGKLABYLZWPZ7PAVCNFSM6AAAAABOGHQ2QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHEYTOMZZGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Seb-The-SamMarten]

Underbarrel gunmod blacklist now populated with the correct mods.

[SirPendrak]

There is still "robofac_handguard" strangely located in robofac_gun.json

There is still case of "bipod_handguard" and "bipod_handguard_deployed". The first one has +4 handling, so you could get +8 with this new angled grip. In theory it could still work with "bipod_handguard_deployed" and have only colapsed version in blacklist, but I am not sure if it could cause some problems when trying to transform attached gunmod when one version is blacklisted. Probably best to blacklist both variants, they get good handling anyway, and if you want best handling with and without using bipod, you can just use standard bipod + the new angled grip.

I see the new grip has "aim_speed_modifier". Does it work on mod that is not a sight? It makes all sights aim faster?
If it works, then why only this kind of grip increases aiming speed?

[Seb-The-SamMarten]

@SirPendrak

It's intended to be used with bipods, so there's no reason to have them blacklisted. The whole point of making it was to give the guns forced to have bipods the option of a forward grip. :P (Unless I am reading the description of those bipods wrong and they are acting as a forward grip when not deployed?)

I didn't even know the "robofac_handguard" existed honestly. But if it's something that has a bipod or restricts the use of the underbarrel for some reason, then it would also be a candidate for being allowed. I'd have to look more into it.

As for when the bipod is actually deployed... hmm... I'm not 100% sure actually. Is there a way to make the bonuses from a part situational? Like, remove the bonus of the grip when the Bipod is deployed? That would probably be the best course if that is something that can be done. If not then... well, not that many guns use bipods, and the ones that do tend to have very poor handling anyway. An extra 4 points of dispersion isn't going to be an enormous, game-breaking boon. xD (Could potentially change the values of the 'deployed' versions of bipods to reduce their factors by 4, but then that would basically require the grip to be installed to make the difference.)

As for why this grip increases aim speed, it's purely because moving your point of contact more horizontal would allow you to turn the gun easier without having to turn your whole body like a standard vertical grip. I kept the number low (and even lowered it more) because it's not going to be an enormous difference, but the difference would still be there.

[Seb-The-SamMarten]

Should hopefully be the last change necessary before this can be properly merged. The big brass catcher will remain without a recipe for now.